Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GDScript] Clean up some unused code #88899

Merged
merged 1 commit into from
Apr 19, 2024
Merged

[GDScript] Clean up some unused code #88899

merged 1 commit into from
Apr 19, 2024

Conversation

AThousandShips
Copy link
Member

These have been unused since:

These should be all the unused parts of this class, came across them working on some other code

@AThousandShips AThousandShips added this to the 4.3 milestone Feb 27, 2024
@AThousandShips AThousandShips requested a review from a team as a code owner February 27, 2024 10:59
Mickeon
Mickeon approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it compiles surely this is fine-

@akien-mga akien-mga merged commit 931f878 into godotengine:master Apr 19, 2024
16 checks passed
@AThousandShips AThousandShips deleted the gdscript_clean branch April 19, 2024 14:29
@akien-mga
Copy link
Member

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mickeon Mickeon Mickeon approved these changes

@vnen vnen vnen approved these changes

Assignees
No one assigned
Labels
enhancement topic:codestyle topic:gdscript
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@AThousandShips @akien-mga @vnen @Mickeon